spacebear
spacebear
I see - @shinghim had included a check in payjoin-cli in #586 but I removed it by mistake while resolving rebase conflicts. See https://github.com/payjoin/rust-payjoin/pull/710. However, I don't think the other...
Ok I was just going to add I'm running into the same issue on master. It works with a different ohttp server.
Considering that currently our only "production" users are using the Dart bindings, I think a priority for 1.0 is to also publish an up-to-date Dart library to https://pub.dev/ and get...
> Couldn't the field clearing and `apply_fee` order be reversed to fix this problem? That's not a bad idea, with some caveats: - We'd have to ensure the weight estimator...
I wonder if we could estimate the receiver input weights/fees by first signing the PSBT in `finalize_psbt`, then applying fees (which we can now do because we know the redeem...
The [reference sender implementation](https://github.com/bitcoin/bips/blob/764e853d20e0249ed660f17d93100d5a91a199fa/bip-0078.mediawiki#reference-senders-implementation) should also be updated to remove this check: ``` // Verify that non_witness_utxo and witness_utxo are not specified. if (proposedPSBTInput.NonWitnessUtxo != null || proposedPSBTInput.WitnessUtxo != null)...
#712 added constructors for: - [x] p2wpkh - [x] p2wsh - [x] p2tr still to-do (pulled from https://github.com/payjoin/rust-payjoin/pull/712#pullrequestreview-2894146847): - [x] p2pkh - [x] p2wpkh-in-p2sh - [ ] Update callsites to...
Upon further digging by @arturgontijo it seems like the constructors for the script-spend types (p2sh, p2wsh, and p2tr in script-spend path) may be unviable. One issue is that it's not...
> The "max expected weight" makes sense for the scripts - these would just apply to the p2sh and p2wsh constructors, right? Yes, and also pt2r in the case of...