spacebear

### Is there an existing issue for this? - [X] I have searched the existing issues ### Current behaviour Calling `walletprocesspsbt` on a signed PSBT that only includes a `witness_utxo`...

Support payjoin PSBT with multiple sender inputs

4

[Compatibility testing with PDK](https://github.com/payjoin/rust-payjoin/issues/51#issuecomment-2100765588) revealed that the JoinMarket payjoin receiver doesn't support signing for PSBTs that contain multiple sender inputs. This patch fixes that.

This is a work in progress. Enables #313 TODOs: - [ ] Finalize new type states - [ ] Randomize output indices - [ ] ~~Input selection~~ - [ ]...

Enable transaction cut-through

5

Background: https://bitcointalk.org/index.php?topic=281848.0 To enable transaction cut-through, receivers should be able to completely replace the Original PSBT output(s) paying them with one or more new outputs, as long as they can...

Review usage of `crate::receive::Error`

1

Follow-up from https://github.com/payjoin/rust-payjoin/pull/277#pullrequestreview-2139827469 Server errors are meant to be returned as a response, but are being returned in places that don't always make sense, e.g.: https://github.com/payjoin/rust-payjoin/blob/4bc8fe362226b07becd5ea8edd839bc5a4ff7a44/payjoin/src/receive/mod.rs#L486 https://github.com/payjoin/rust-payjoin/blob/37d255e9e5e4b4aeeb8c75f96e09cbb69c00552b/payjoin-cli/src/app/v1.rs#L318 https://github.com/payjoin/rust-payjoin/blob/37d255e9e5e4b4aeeb8c75f96e09cbb69c00552b/payjoin-cli/src/app/v2.rs#L345 It would...

Use native rust-bitcoin methods for weight calculations

2

See https://github.com/payjoin/rust-payjoin/issues/353 This deletes the custom `weight.rs` traits and `input_type.rs` helpers in favor of out-of-the-box rust-bitcoin methods. It also removes the unused `output_type.rs`. A question that may be relevant to...

We should be able to rip out our [custom](https://github.com/payjoin/rust-payjoin/blob/master/payjoin/src/output_type.rs) [code](https://github.com/payjoin/rust-payjoin/blob/master/payjoin/src/input_type.rs) for [weight calculations](https://github.com/payjoin/rust-payjoin/blob/master/payjoin/src/weight.rs) and simply use `rust-bitcoin`'s [weight prediction methods](https://docs.rs/bitcoin/latest/bitcoin/blockdata/transaction/fn.predict_weight.html) in its place.

Add adverserial tests

1

The official BIP78 test vector checks the happy path where both the sender and receiver act honestly. To catch and prevent [bugs](https://github.com/payjoin/rust-payjoin/pull/338) that may result in loss of funds, we...

Wrap URI errors in a payjoin type

2

> We should almost definitely be wrapping bitcoin_uri::de::Error> in a payjoin type. _Originally posted by @DanGould in https://github.com/LtbLightning/payjoin-ffi/pull/71#discussion_r2033982267_

Move shared response processing code to ohttp.rs

2

The `process_res` methods across send and receive have a lot of shared code that can be extracted into reusable functions. `process_get_res` and `process_post_res` essentially do the same thing, and could...