spacebear

There is actually [already a test](https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/test/jmclient/test_payjoin.py#L145) for this case, but the sender is skipping some checks from the [BIP78 checklist](https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#senders-payjoin-proposal-checklist) that would catch this issue (specifically, "If it is one...

@AdamISZ Thanks for the thorough review! Want me to remove that `assert` https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1700/commits/67ba0f5528b26a99ba888dd797338aca1eb71b6a then? I mainly put it there to highlight the check that _should_ happen somewhere, likely in that...

OK, makes sense and agreed. I removed that assert.

Closed by https://github.com/payjoin/rust-payjoin/pull/332

I've tested sending from JoinMarket to payjoin-cli and found the bug described below. ### Setup notes JoinMarket doesn't trust self-signed certificates, so I had to obtain a legit certificate from...

This is what i think is happening: 1. Joinmarket sends the PSBT with its own input signed. - This PSBT input only includes a `witness_utxo` (no `non_witness_utxo`), which is legal/encouraged...

> 1. Respect `disableoutputsubstitution` [payjoin-cli should respect output substitution #238](https://github.com/payjoin/rust-payjoin/issues/238). Are you going to take this one on @grizznaut ? This seems like the most important point to address. I'll...

The output substitution fix is here: https://github.com/payjoin/rust-payjoin/pull/239. Unfortunately this isn't enough to fix the joinmarket->payjoin-cli flow because the transaction details still gets updated in other places (receiver input, sender fees)...

Hmm good point, that could work. I'll try to patch it in and attempt another receive from joinmarket.

Nice, that worked! Successfully received from joinmarket with [these changes](https://github.com/payjoin/rust-payjoin/pull/241/files).