spacebear
spacebear
Accidentally closed
v2-to-v2 is [now covered](https://github.com/payjoin/rust-payjoin/blob/master/payjoin-ffi/tests/bdk_integration_test.rs#L235). v1-to-v2 and v2-to-v1 are missing from payjoin-ffi integration tests.
I think this would look like: 1. payjoin-cli accepts a list of `ohttp_relay`s in config, instead of a single relay. 2. Whenever payjoin-cli sender/receiver makes a request, pick one ohttp_relay...
Closing as stale and due to the feature freeze for 1.0 milestone
Additional thoughts: Once #616 is merged and deployed, this issue becomes much less serious because the default session expires after 24 hours, so old key configurations should always be valid...
Also note that payjoin-cli correctly stops looping [on any `process_res` error](https://github.com/payjoin/rust-payjoin/blob/master/payjoin-cli/src/app/v2.rs#L210), but other implementations may not. This is likely due to language bindings [not exposing enough error details](https://github.com/LtbLightning/payjoin-ffi/issues/48) currently.
Thanks for the reviews @DanGould and @chavic, I think I addressed all of your comments in the latest push and replies.
Closing this and #594 as no clear direction was decided on.
I agree this should be solvable by manually calculating the `redeem_script` length for `p2sh` inputs, or the `witness_script` length for `p2wsh` inputs. The primary reason I didn't implement it is...
Can this issue be closed now?