spacebear

Results 94 comments of spacebear

This got auto-closed by #982 but I guess the issue should still be open

While we're doing this, I'd like to see `SelectionError` renamed to `CoinSelectionError` for max clarity.

Until we're sure we can remove the `Internal` types we may want to consider making those `pub(crate)` so that testers can check for specific error types.

It would be great to revive this and get this in, which would also solve the Github issues when downloading bitcoind from the core releases: ``` error: failed to run...

Closing this issue as prometheus metrics were introduced in #848, and there are much more in-depth issues/discussions on this topic in #941, #735, #775

We should definitely narrow the scope down to a reasonable number to start, kill those mutants, then gradually expand from there. IMO a good place to start would be the...

IIUC "unviable" just means it fails to compile with the attempted mutation, meaning the Rust compiler effectively tests that behavior for us so these are safe to ignore.

Wow, not a single missed mutant when including e2e tests?? That's almost hard to believe... My hunch is that we should not rely on crates external to `payjoin` for mutation...

Per https://github.com/payjoin/rust-payjoin/pull/748, I think we can safely consider mutation testing "introduced" :p Thanks @benalleng for your work on this!