Ryan Ofsky
Ryan Ofsky
Rebased a09c21c05a9adf0ca5a4b6a15021b45c6c2e0b2a -> e7457d0acefeccd636c134d0c10567ffaade2fc7 ([`pr/bresult-load.2`](https://github.com/ryanofsky/bitcoin/commits/pr/bresult-load.2) -> [`pr/bresult-load.3`](https://github.com/ryanofsky/bitcoin/commits/pr/bresult-load.3), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/bresult-load.2-rebase..pr/bresult-load.3)) due to conflict with #25616 Rebased e7457d0acefeccd636c134d0c10567ffaade2fc7 -> 874003fcea81aba1276b53d5ad9c5dadefddd5ff ([`pr/bresult-load.3`](https://github.com/ryanofsky/bitcoin/commits/pr/bresult-load.3) -> [`pr/bresult-load.4`](https://github.com/ryanofsky/bitcoin/commits/pr/bresult-load.4), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/bresult-load.3-rebase..pr/bresult-load.4)) due to conflict with #25504 Rebased 874003fcea81aba1276b53d5ad9c5dadefddd5ff -> d020d0cce052bc7b4141347a51d34fd85f8a10a1...
I think it would be good to log a warning if reindex is specified in the configuration file, but still allow it. It seems to me there may be a...
> This is the kind of work that's easy enough to get 90% of the way there, but the remaining 10% will almost certainly be brutal. I'm probably naive, but...
> dongcarl fanquake ryanofsky theuni > > Your conceptual assessments of this PR will be much appreciated. Definitely major concept ACK from me. And the implementation seems very clean. I...
Just to explain my concept ACK a little bit: I don't think CMake build needs to add much of a maintenance burden and don't think it needs to have parity...
> it's guaranteed to significantly impede more interesting (and important) long-term efforts. My point is that this is only true if you require parity between the two build systems. I...
@theuni, I think you not making a clear enough distinction between maintaining a build system, and adding new features to a build system. I can attest to the difference personally....
> @ryanofsky Please re-read my comments and please don't twist my words. Nowhere to I advocate for autotools. I hate it. it's dated and awful. In each comment I've advocated...
Concept ACK. It would be good know more about specific use-cases for this, if you can provide some links or more description. But the implementation seems very simple, so I...
Reiterate weak concept NACK see https://github.com/bitcoin/bitcoin/pull/20204#issuecomment-713069277. This change is a bad change. It's a perfect example of dumb, unreasoning, cargo-cult design (there is no design discussion here) copying a poorly...