Ryan Ofsky

Results 636 comments of Ryan Ofsky

@Sjors I'm wondering which mining PRs & issues to focus on since there seem to be a lot open now. Feel free to tag me on any or mention any...

> I think I'm going to combine these two observations and make this PR a breaking change. Marking as draft for now. This seems ok, but isn't really what I...

Haven't looked at code yet, so forgive if these are dumb questions, but could be nice if PR description addressed these: - Is there a way to pass `bitcoin-cli` RPC...

Concept ACK on the idea. I think it probably makes sense to allow options arguments to follow non-option arguments even this change is not strictly backwards compatible, as long as...

Assuming we are ok with losing some backwards compatibility by starting to treating arguments that begin with `-` as options instead of non-options when they follow arguments that don't begin...

I think the second fix mentioned above "Calling removeSyncCleanup from EventLoop thread" should be possible by adding a `ProxyClient::close` method that calls `EventLoop::sync` to unregister `m_disconnect_cb` from the event loop...

Updated 395e3266b5e29a3241e8ea6c5e4024971c21dd39 -> a5b8a2a3293a9650feab1101afa35a1d47981049 ([`pr/errs.1`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.1) -> [`pr/errs.2`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.2), [compare](https://github.com/ryanofsky/libmultiprocess/compare/pr/errs.1..pr/errs.2)) to fix iwyu errors (https://github.com/bitcoin-core/libmultiprocess/actions/runs/17990500563)

Updated a5b8a2a3293a9650feab1101afa35a1d47981049 -> 0ce75e3162bcc605757cd36cb3b90541d7a13a88 ([`pr/errs.2`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.2) -> [`pr/errs.3`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.3), [compare](https://github.com/ryanofsky/libmultiprocess/compare/pr/errs.2..pr/errs.3)) rewrite type-context.h comment to try to describe the error better

Rebased 0ce75e3162bcc605757cd36cb3b90541d7a13a88 -> 7283a2b3d3b9acbc1b3939ef054f1d1537cdfebd ([`pr/errs.3`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.3) -> [`pr/errs.4`](https://github.com/ryanofsky/libmultiprocess/commits/pr/errs.4), [compare](https://github.com/ryanofsky/libmultiprocess/compare/pr/errs.3-rebase..pr/errs.4)) to fix conflict with #220, and also applied review suggestions, and renamed `TypeName` to `CxxTypename` since there is actually already another `TypeName`...

gnu32 CI job is failing but I think it is not directly related to changes in this PR. The new thread busy test introduced in #214 is segfaulting here but...