Ryan Ofsky
Ryan Ofsky
IIUC, the second commit "qt: Move wallet preloading out of model constructors" (e2ffc98e73df68d0de9755d2ebbb26daa17c92fc) seems like a good change, moving wallet "preloading" tasks off of the GUI thread into timer threads...
> > > I think it would be less surprising and more obvious what is going on if we clear the values after the user disables the option. Like, immediately...
> I'm for the prev values approach. All right, it sounds like most people prefer storing disabled values over resetting them, and PR #603 implements the change that's been asked...
I think I have a similar question to luke. With this PR Now there are two different manual deletions for wallet handler in two different places. The `BitcoinApplication::requestShutdown()` method has:...
I agree this the approach in this PR is clean and simplifies code. I think I'm just wondering if it is sufficient to only delete the splash screen object in...
re: https://github.com/bitcoin-core/gui/pull/605#issuecomment-1137436764 > OTOH, BitcoinApplication::initializeResult() is called via Qt::QueuedConnection from the "qt-init"/"shutoff" thread. Therefore, there are no guarantees that it always happens before BitcoinApplication::requestShutdown() (for example, in case when the...
I think you could just use QSettings for this, the same way the GUI datadir preference and all other other GUI-only settings are stored in QSettings. Even https://github.com/bitcoin/bitcoin/pull/15936 which consolidates...
I guess thinking more generally, for example if we did want to add a `changenetwork` RPC that would save a different network preference and restart, I'd probably do that by...
This seems harmless, but why is not possible to have different icons on macos like we can have on windows or linux? Is this an operating system limitation? An installer...