Ryan Ofsky

refactor: Use util::Result class for wallet loading

14

**This is based on #25665 + #26022.** The non-base commits are: - [`40ccdcc208de` Add temporary ResultExtract helper for porting to util::Result](https://github.com/bitcoin/bitcoin/pull/25722/commits/40ccdcc208dea611d23ed003d21e427c92517c69) - [`723c2c7c48ca` refactor: Use util::Result class in wallet/sqlite](https://github.com/bitcoin/bitcoin/pull/25722/commits/723c2c7c48ca633aae6a63561b7ef5f361f742f5) -...

Get mitogen.fakessh module working again

4

Fixes include - Setting cloexec flag on pipe files, using set_inheritable on sockets, and close_fds=False on subprocess.Popen to work around file descriptors not being inheritable by default in new versions...

Add settings.json prune-prev, proxy-prev, onion-prev settings

8

With #602, if proxy and pruning settings are disabled in the GUI and the GUI is restarted, proxy and prune values are not stored anywhere. So if these settings are...

RFC: Is it OK to reset unused prune and proxy settings to default values after restarting?

4

I'm opening this issue to get feedback and figure out how to resolve a disagreement that came up in https://github.com/bitcoin/bitcoin/pull/15936#discussion_r850568749. ### Background PR https://github.com/bitcoin/bitcoin/pull/15936 unifies Bitcoin-Qt and Bitcoind settings so...

Detect non-minimal UTF-8 decoding

8

Fixes following test failures in https://github.com/nst/JSONTestSuite bitcoin SHOULD_HAVE_FAILED n_string_overlong_sequence_2_bytes.json

multiprocess: Add bitcoin-wallet -ipcconnect option

5

**This is a draft PR because it is based on #29409 + #10102.** The non-base commits are: - [`be6795a29264` multiprocess: Add bitcoin-wallet -ipcconnect option](https://github.com/bitcoin/bitcoin/pull/19460/commits/be6795a292645871f1976daaa00fd19b11bea6ae) --- Building on #10102, this adds...

refactor: Replace `std::optional<bilingual_str>` with `util::Result`

2

Replace uses of `std::optional` with `util::Result` as suggested https://github.com/bitcoin/bitcoin/pull/25648#discussion_r936311768 **This is based on #25665.** The non-base commits are: - [`f1a9c713540` refactor: Replace std::optional with util::Result](https://github.com/bitcoin/bitcoin/pull/25977/commits/f1a9c713540b3f00cea3c29ace4958b77390a8ef)

Add util::ResultPtr class

9

**This is based on #25665.** The non-base commits are: - [`120dfb39d46c` Add util::ResultPtr class](https://github.com/bitcoin/bitcoin/pull/26022/commits/120dfb39d46cb1f13df0020843d4adf86e458be9) - [`6efb6d865e90` Use ResultPtr instead of Result](https://github.com/bitcoin/bitcoin/pull/26022/commits/6efb6d865e90ff346c33fc39dc5e28a1192b3d12) --- The `util::ResultPtr` class is a wrapper for `util::Result`...

indexes: Stop using node internal types and locking cs_main, improve sync logic

49

This PR lets indexing code mostly run outside of the node process. It also improves indexing sync logic, which is moved out of indexing code to a new [`node::SyncChain()`](https://github.com/ryanofsky/bitcoin/blob/cf6d99bed842361fb06986780097fb80c9e879e4/src/node/chain.h#L21-L36) function....

refactor: Add util::Result failure types and ability to merge result values

56

Add `util::Result` support for returning more error information and make use of it in [LoadChainstate method](https://github.com/bitcoin/bitcoin/pull/25665/commits/0ad3a45633433377b44c9ae89b52703e0c750fdd) as an initial application. Followup PRs [#25722](https://github.com/bitcoin/bitcoin/pull/25722) and [#29700](https://github.com/bitcoin/bitcoin/pull/29700) use it more broadly to...