Ryan Ofsky

Results 636 comments of Ryan Ofsky

> The bitcoin-gui executable is ignoring testnet=1 in bitcoin.conf This is fixed now. It was caused by a bad rebase of this PR, which neglected to call `SetupServerArgs` in the...

> createwallet "test" froze the app for me This is fixed in pr/ipc.56

Thanks for the report @fingera. The gcc compile errors should be fixed now (I've been testing with clang more than gcc recently). --- Updated 5ce9a948c8ec47762d0a23d1cf7f2ce57386052b -> f896f063007aa3889caf9d14724357117eca78c1 ([pr/ipc.55](https://github.com/ryanofsky/bitcoin/commits/pr/ipc.55) -> [pr/ipc.56](https://github.com/ryanofsky/bitcoin/commits/pr/ipc.56))...

Thanks for testing! I will test the createwallet method, fix git ignores, and clean up the disconnect handling so leftover processes won't stick around if one crashes. On location of...

re: https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-428086112 > Don't forget to update .gitignore Updated now. re: https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-428086112, https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-416028413 > I do still get the syscall deprecated in macOS 10.12 warning Should be fixed now. Worked...

re: https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-495959606 @jb55 this looks like it's caused by changes between capnproto 0.7.0 and 0.6.1: https://github.com/capnproto/capnproto/issues/772. I don't think it should be too be hard to add compatibility with 0.7.0,...

Draft PR since I want to add a commit taking advantages of ability to return chain results and return warnings.

Moved out of draft, since result interface is more complete now and there's more code using it

Thanks, Marco! I will just tweak #25721 to be a standalone PR instead of depending on this PR

> Thanks, Marco! I will just tweak #25721 to be a standalone PR instead of depending on this PR This is done now