Alexander Poss

Hatchery interferes with "Run"

1

The new feature to Run with ROS launch interferes with other Run processes. For example, if I try to run a Python file, Hatchery's ROS launcher will try to run...

Install missing

2

Unfortunately, this example is missing the install step. QML plugins / modules / extensions (whatever you may call it) should be installed in `QT_INSTALL_QML`. Please take a look at the...

v2 components naming

10

Does it have any disadvantages using the v2 components? If not why not make them the default and rename the old-style components to v1?

HalThread class missing in Python API

1

It would be useful to have a `HalThread` class that contains name and period which is returned by `rt.newthread`. This class could then be re-used by `hal.addf` instead of using...

HAL pin cannot be owned in new-style Python API

1

A pin created via the `from machinekit import hal` API cannot be owned and therefore not be used to create userland components. E.g.: ```python self.halcomp = hal.Component(self.compname) self.halpin = self.parent_comp.newpin(self.name,...

Currently, the `config-pin` utility sleeps after loading a cape. However, it might be more suitable to wait for the cape to actually appear instead as described here: https://groups.google.com/d/msg/machinekit/V0LWXYFQXfM/VSV3J7QHBAAJ

The linter of CLion IDE reported a couple of problems and optimizations in the code. Most noteworthy is the `time_now` change, since the `ROS_WARN_THROTTLE` call overwrites the local `now` variable.

race condition in SimpleActionClient

1

I noticed that `wait_for_result()` may cause a race condition. The `done_condition` lock is not used when setting the simple_state, therefore `done_db` might not have been called when `wait_for_result` returns. see...

Ignoring errored service requests

6

## Bug report **Required Info:** - Operating System: - Ubuntu 18.04 - Installation type: - Build from source - Version or commit hash: 46baa889bcb9808b5b461f98faee520a90d57347 - DDS implementation: FastRTPS - Client...

This PR fixes the inconsistent code formatting used throughout the source to conform to the ROS C++ standard using `clang-format` and @davetcoleman's `.clang-format` config: https://github.com/davetcoleman/roscpp_code_format/blob/master/.clang-format Moreover, this patch also adds...