race condition in SimpleActionClient

Open machinekoder opened this issue 5 years ago • 1 comments

I noticed that wait_for_result() may cause a race condition. The done_condition lock is not used when setting the simple_state, therefore done_db might not have been called when wait_for_result returns.

see https://github.com/ros/actionlib/blob/noetic-devel/actionlib/src/actionlib/simple_action_client.py#L239-L243 and https://github.com/ros/actionlib/blob/noetic-devel/actionlib/src/actionlib/simple_action_client.py#L137-L138

Nov 23 '20 18:11 machinekoder

related to https://github.com/ros/actionlib/issues/116

Nov 23 '20 18:11 machinekoder