Justin Bertram

Results 142 comments of Justin Bertram

The name "SerialFilter" is used throughout the changes. However, I think this should be changed to "DeserializationFilter" in order to be more accurate about what it is and to be...

That's a nice win because those lists and their associated methods need to be deprecated anyway since the black/white terms have been deemed non-inclusive (see more at [ARTEMIS-3474](https://issues.apache.org/jira/browse/ARTEMIS-3474)). With the...

Go ahead and add `@Deprecated` where necessary, but don't remove anything yet. We'll have to wait for a major version before we can do that. The new documentation will need...

At this point it appears this PR has been abandoned. Furthermore, it has numerous conflicts. Therefore, I will go ahead and close this PR. @swerner0, please re-open it with updates...

FWIW, you can update your branch, push -f, and then re-open this PR when you're ready.

In my opinion, inspecting the documentation from the diff is difficult. I'd recommend pulling the PR and [building the docs](https://activemq.apache.org/components/artemis/documentation/hacking-guide/#only-docs). Then you can really see the new content and flow.

@clebertsuconic, that's a fair point. I updated the Jira and commit message to reflect this.

@ehsavoie, is merging this going to cause any problems for WildFly? Are you guys using `org.apache.activemq.artemis.core.config.ha.DistributedPrimitiveManagerConfiguration`. I'm guessing you don't since you don't ship either of the current `artemis-quorum-api` or...

@clebertsuconic, I think this is ready to go.