Justin Bertram

Results 142 comments of Justin Bertram

To be clear, I am happy to merge your commit eventually. I just want the Jira/commit association to be clear for posterity's sake.

At this point two main things are not clear in your commit: 1. How to use your new Docker file. 2. How your new Docker file fits with the other...

I'm still in the process of testing all the changes locally. I have other priorities on my plate at the moment so progress has stopped at the moment. @SamTV12345, is...

@clebertsuconic, can you take a look at this as well since I believe you originally created the Docker files.

> I'd like to get this pr merged as soon as possible so I can move on to the next ticket. Is this PR a dependency for another task you're...

@SamTV12345, FWIW instructions on how to build are in the ["Building" chapter of the Hacking Guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/building.md): > To build the full release with documentation, Javadocs, and the full web site:...

@SamTV12345, I'm not sure where that's coming from. Searching the code-base for `os.detected.classifier` turns up 0 results. What exact command did you execute and what branch are you on? Also,...

I reproduced the error by executing `mvn dependency:go-offline`. It's not clear to me whether the problem is in the ActiveMQ Artemis `pom.xml` or in one of Netty's. What happens if...

Looks like this can be fixed by adding this to the `` of the main `pom.xml`: ```xml kr.motd.maven os-maven-plugin 1.7.1 ```

I rarely (if ever) use Maven's offline mode as downloading dependencies isn't a problem for me, but I sent #4355 to support those who need it. Hope that helps!