Justin Bertram

Results 142 comments of Justin Bertram

Those numbers seem excessive to me. When I eliminate the time required to download artifacts by first using `mvn dependency:go-offline` and then run: ``` mvn -o clean install -Prelease -DskipTests...

I went a different direction on this. You can see it on #4702. See the updated description on [ARTEMIS-4498](https://issues.apache.org/jira/browse/ARTEMIS-4498) for additional details.

@AntonRoskvist, FWIW I think this was a good PR. I didn't want to ask you to make all the changes to implement what I eventually sent in #4702. However, now...

@AntonRoskvist, thinking about this more I want to go with this PR rather than #4702. I like the simplicity of just enabling management for everything.

The previous failures have been resolved, but these are failing now: - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=true,supportAdvisory=false,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=true,supportAdvisory=false,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=true,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=true,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=true,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=true,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=false,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=false,suppressJmx=true] The problem is...

This looks good. Thanks for the contribution! However, before merging this needs a couple of things... First, it needs an associated Jira. If you don't already have an Apache Jira...

@cardamon, do you plan on following up on this PR with the requested changes?

Checkstyle violations: ``` [INFO] There are 5 errors reported by Checkstyle 10.11.0 with /home/runner/work/activemq-artemis/activemq-artemis/tests/integration-tests/../../etc/checkstyle.xml ruleset. Error: src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/UnsynchronizedClusterReproducer.java:[123,49] (whitespace) WhitespaceAround: '{' is not followed by whitespace. Error: src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/UnsynchronizedClusterReproducer.java:[137,77] (whitespace) WhitespaceAround: '{'...

I had the same thought about using the topology update to know when the "original" node came back. I think that would be simpler than manually checking and it would...

Isn't the use-case in view here live-to-live failback after failover (implemented recently via [ARTEMIS-4251](https://issues.apache.org/jira/browse/ARTEMIS-4251))? I'd leave live/backup pairs out of this completely since there are already semantics in place for...