Justin Bertram
Justin Bertram
There _is_ a short sentence in each commit message indicating what the commit is for.
@michaelandrepearce, any additional feedback here?
@eidottermihi, go for it!
@ryan-highley, can you squash and rebase?
Fixed via #4181.
@franz1981, @clebertsuconic, @michaelandrepearce, where are we on this? Is this something we still want to do? Netty's io_uring lib is still in their incubator, but it's up to 0.16 now.
@michaelandrepearce, given the silence from @franz1981 I'd say you should go ahead and send a PR of your own with the changes you recommended (plus resolving the existing conflicts). Then...
I went ahead and cleaned this up and merged it since it had been sitting idle for so long. Thanks for the contribution, @nbrendah!
@ryan-highley, the test failure was unrelated and I've pushed a fix for it. Please `git commit --amend` and push your branch again to trigger a rebuild.
@michaelandrepearce, are you still -1 on this change? It looks good to me.