Justin Bertram

Results 141 comments of Justin Bertram

The real way to fix `QueueControlUsingCoreTest` is just to tell `invokeOperation` to cast it to an `Integer.class`, e.g.: ```java @Override public int sendMessagesToDeadLetterAddress(final String filterStr) throws Exception { return (Integer)...

I definitely prefer leaving the existing behavior as-is and adding a new configuration parameter. Changing defaults in a minor a release typically results in a poor user experience. Also, I...

This idea has merit, but there a couple problems: - The code isn't formatted properly so CheckStyle is failing. - The retry is limited to `org.apache.activemq.artemis.core.io.nio.NIOSequentialFile#open(int, boolean)`, but there are...

> Do you think the points you mentioned are the ones that should complete it? I can't speak for anyone else, but as far as I'm concerned I would say...

I'm converting this to a draft and removing the `DO-NOT-MERGE-YET` label. Using the draft functionality is a bit more elegant. That said, it would be great to either get this...

@franz1981, just a friendly reminder that it's been a week. This looks like a nice feature so it would be nice to get it out to the community if it's...

I think that a better approach might be to create 3 sub-modules under `artemis-junit`. You could have `artemis-junit-4`, `artemis-junit-5`, and then `artemis-junit-commons` for all the bits they share. I'm not...

@ViliusS, can you quantify the difference this will make in the size of the image? For what it's worth, lots of folks use JDK tools during development **and** production (e.g....

@ViliusS I think having the option to choose JRE or JDK would be great since one size doesn't fit all in this case.

Couple of things: - Ideally the broker would automatically detect the use of the proxy protocol by a client. We already do lots of automatic protocol detection so that a...