activemq-artemis icon indicating copy to clipboard operation
activemq-artemis copied to clipboard

ARTEMIS-4559 refactor HA docs & code/module naming

Open jbertram opened this issue 2 years ago • 3 comments

This commit does the following:

  • Updates HA docs including the chapter on network isolation (i.e. split brain). The network isolation chapter is now more about high-level explanation and the HA doc now has all the configuration parameters.
  • Changes references to "pluggable quorum voting" to "pluggable lock manager." The pluggable functionality really isn't about voting. Conceptually is much more like the functionality you'd get from a distributed lock so this naming is more clear. Both the docs and the code have been changed, but all changes are backwards compatible.
  • Reorganize lock manager modules as sub-modules. The API and RI modules are renamed, but that should be OK based on the "experimental" tag that's been on this feature up to this point.
  • Remove the "experimental" tag from the lock manager.

jbertram avatar Jan 09 '24 05:01 jbertram

In my opinion, inspecting the documentation from the diff is difficult. I'd recommend pulling the PR and building the docs. Then you can really see the new content and flow.

jbertram avatar Jan 09 '24 16:01 jbertram

This is a big beyond refactoring just docs, right? you're also renaming the package and project name?

not complaining about the change.. just noticing it's a bit more than just doc changes?

clebertsuconic avatar Jan 22 '24 20:01 clebertsuconic

@clebertsuconic, that's a fair point. I updated the Jira and commit message to reflect this.

jbertram avatar Jan 22 '24 20:01 jbertram

@ehsavoie, is merging this going to cause any problems for WildFly? Are you guys using org.apache.activemq.artemis.core.config.ha.DistributedPrimitiveManagerConfiguration. I'm guessing you don't since you don't ship either of the current artemis-quorum-api or artemis-quorum-ri jars.

jbertram avatar Mar 06 '24 19:03 jbertram

@jbertram I don't think so but I'll do a quick run tomorrow

ehsavoie avatar Mar 06 '24 20:03 ehsavoie

@jbertram LGTM

ehsavoie avatar Mar 07 '24 11:03 ehsavoie

@clebertsuconic, I think this is ready to go.

jbertram avatar Mar 08 '24 18:03 jbertram