Benedikt Franke

Results 536 comments of Benedikt Franke

> What is the best way to integrate lampager and lighthouse? Create an open source package or add a PR to Lighthouse. You will have to put in some effort,...

@dbbk that would make the client side state handling much harder, it would have to keep track of all pages that were seen. If the goal is to have the...

- The client would not able to navigate back to a previous page easily. - Passing a mutable list back and forth introduces state. - Efficiency for large lists might...

We have to keep in mind that cursor pagination in Laravel is subject to some limitations which our current pseudo-cursor implementation does not have. This means that we cannot simply...

@dbbk see https://laravel.com/docs/pagination#cursor-pagination

I appreciate the discussion and hearing your opinion on the matter. Keep in mind that I am giving a lot more weight to what actual contributors to the project have...

I could see extending [`@validate`](https://github.com/nuwave/lighthouse/blob/master/src/Validation/ValidateDirective.php) like this: ```graphql """ Run validation on a field. """ directive @validate( """ References functions that receive the `Illuminate\Contracts\Validation\Validator` after validation is completed. Consists of...

How about we add an option to `php artisan lighthouse:ide-helper` that allows not generating built-in directives?

As of very recently,repeatable directives are now allowed in principle. We will have to add support for that: https://github.com/nuwave/lighthouse/issues/1133 I think allowing multiple `@with` will be the best solution for...

Repeatable use of the directive is not generally the issue here, it should work in principle - and is now also supported by `webonyx/graphql-php` As of now, the way the...