Benedikt Franke

icon indicating a website link https://franke.tech icon indicating an email [email protected]

icon company @mll-lab icon location Munich, Germany icon location I like to bring order to chaos. Structuring data, writing clean code and optimizing processes - I produce great results and learn along the way.

Results 536 comments of Benedikt Franke

Test usage with subscriptions

Interesting, could you give this a shot? You already touched the relevant parts of the codebase in your recent PR.

Add custom instrumentation through a span

Yeah. I have been trying to replace the `fetch` breadcrumbs, but found that I was lacking the tracing information. ![image](https://user-images.githubusercontent.com/12158000/106907492-97d55900-66fe-11eb-8fe5-866aac416958.png) You can see how the `fetch` breadcrumb references the span...

Implement session based authentication with Sanctum

Thanks for the thorough review @dlindenkreuz, I think we are making good progress towards an optimal and minimal solution.

QueriesFlaggedEnum::hasFlag broke on invalid argument signature

Open for pull requests.

feat: Introduce `variable_case` fixer

Thanks @jmkoni for your work on this PR. We are trying to add this as a custom rule via https://github.com/mll-lab/php-cs-fixer-config/pull/3 and stumbled upon some edge cases: ```php $_ = 2;...

@can don't work with simple gate

`@can` expects a model to check the ability against. Since you do not provide one explictly, Lighthouse guesses that your model is called `String` and looks for such a class.

Correctly handle leaf inputs that were cast to PHP native enum instances

How did you define your enum in the schema - did you implement a conversion to native enums akin to https://lighthouse-php.com/master/the-basics/types.html#enum? If not, the values would just be the -...

Correctly handle leaf inputs that were cast to PHP native enum instances

I would like to keep this issue open, as it is a problem that is generally present with leaf values that are cast into non-primitive values.

Correctly handle leaf inputs that were cast to PHP native enum instances

Could implementing `__toString()` in the enum class solve both issues at once?

EnsureXHR blocking file uploads

@Deyjandi has just recently opened a pull request that probably deals with the same underlying problem, see https://github.com/nuwave/lighthouse/pull/2202.