Benedikt Franke comments

Results 536 comments of


                                            Benedikt Franke

Apply schema manipulation on input field definitions

@henzeb that would be great. Let me know if you require further clarification for what needs to be done, I hope the issue description is clear enough.

@inject context user returns null with multi-guards

Using multiple guards is supported somewhat badly. Could you set up a PR with a failing test case as the basis for implementing a fix?

Allow styled-components 5 peer-dependency

@azz can you take a look? I think this change would benefit many users.

Allow styled-components 5 peer-dependency

@azz If you no longer want to support this package, that is completely fine. A deprecation notice and archival of the project would be nice in that case, so that...

generateConfig for date-fns throws error for some locales

I created a pull request to fix this: https://github.com/react-component/picker/pull/289

fix: map to correct locales for date-fns

I thought about a generalized solution, but in this case it is not worth it. Creating this pull request took me a few minutes of (admittedly tedious) work, but saved...

omitDeep mutates objects

For anyone having this same issue, I can recommend `omit-deep-lodash`. It does not mutate inputs, as evidenced by https://github.com/odynvolk/omit-deep-lodash/pull/16

Specify level for sentry enrichments

After using this for a while, i found the use of `setTransaction` to be a complete semantic mismatch. I am using routes as transactions for now and turned it off....

Importing apollo-link-sentry package gives 350kb of unwanted and unused code.

Open for suggestions or pull requests to fix this, I do not plan to work on this myself.

Document recommended way to limit size of breadcrumbs

Open for improvements to the API or the docs.