Benedikt Franke

Results 537 comments of Benedikt Franke

Alright, please provide a pull request with a failing test case then.

I have no plans to implement this, but if it is easy enough i am open for PRs.

We should use native SDL for changing the name of the root types, see http://spec.graphql.org/draft/#sec-Schema

It is not that hard. Basically, somewhere in the schema definition - probably `schema.graphql` - there can be a definition like this: ```graphql schema { subscription: CustomSubscription } ``` This...

Marked this as a draft, as the implementation is not based upon SDL yet. > I am not sure how it should be tested whether actually changing the values work?...

It would be great to see the docs for this improved. I have never used subscriptions myself, so I can not help much.

@wimski has written up a great summary and potential solution for this issue in https://github.com/nuwave/lighthouse/issues/1830

Perhaps we need to swap out some of the validation rules in `webonyx/graphql-php` with our own implementations: https://github.com/webonyx/graphql-php/blob/bb60eb49bd77dd04b78ff7e54d0098d3f075d261/src/Validator/DocumentValidator.php#L140-L167

You can create a PR in `webonyx/graphql-php` to make those into `protected/static`.

My initial impression is that this feature is unnecessary and quite complicated to fit in with existing functionality in Lighthouse. See https://github.com/nuwave/lighthouse/blob/master/src/Schema/Directives/UpdateDirective.php Directive resolvers are meant to be useful abstractions...