Benedikt Franke

icon indicating a website link https://franke.tech icon indicating an email [email protected]

icon company @mll-lab icon location Munich, Germany icon location I like to bring order to chaos. Structuring data, writing clean code and optimizing processes - I produce great results and learn along the way.

Results 536 comments of Benedikt Franke

Documentation on Pusher webhook is wrong

That's great, please create a PR to update the docs.

Allow constraining allowed relations in `@whereConditions` and `@whereHasConditions`

@LastDragon-ru please review.

Providing an unknown field as if it were a list results in cryptic error

Please open an issue with the upstream library https://github.com/webonyx/graphql-php. We can fix it in Lighthouse by updating our dependency after it has been fixed there.

Allow wildcard(*) in config namespace

I might merge a pull request for this, given it is simple enough to implement and does not hurt performance.

Sending tracing to Apollo Studio

@andrewmclagan feel free to create a pull request. This can probably be integrated in the tracing module, see https://github.com/nuwave/lighthouse/tree/master/src/Tracing. It should be an optional feature that is activated through a...

Add @api to mark elements of our public API

Interfaces are great when we have classes that the user may want to plug into or subsitute the implementation. Not all classes or methods we provide fall under that category....

Add @api to mark elements of our public API

@georgeboot This issue does not have anything to do with the GraphQL schema. It is about adding PHPDoc annotations to our code.

Lighthouse should not return the 'data' key if an exception was thrown in the custom builder

That behavior is expected, given the return type of your field is most probably nullable (not marked with `!`). In that case, returning `null` for the field is what should...

Lighthouse should not return the 'data' key if an exception was thrown in the custom builder

The first step towards getting this fixed is to create a PR with a failing test case.

Using query variable as a parameter in a nested field

You can use the following channels to ask support questions: - [Use the laravel-lighthouse tag on Stackoverflow](https://stackoverflow.com/questions/tagged/laravel-lighthouse) - [Hop into Slack](https://join.slack.com/t/lighthouse-php/shared_invite/enQtMzc1NzQwNTUxMjk3LWMyZWRiNWFmZGUxZmRlNDJkMTQ2ZDA1NzQ1YjVkNTdmNWE1OTUyZjZiN2I2ZGQxNTNiZTZiY2JlNmY2MGUyNTQ) This repository and the issue tracker are used to...