rtpsw
rtpsw
> Now that #14415 has merged we can move forwards on this. However, the code here is out of date (it was based on an older revision of #14415) and...
I ended up merging. @westonpace, does it look like what you expected?
How to deal with the following [CI job's](https://github.com/apache/arrow/actions/runs/3557712768/jobs/5975904381) error? ``` /arrow/cpp/src/arrow/engine/substrait/options.h:37: error: documented symbol 'enum ARROW_ENGINE_EXPORT arrow::engine::arrow::engine::ConversionStrictness' was not declared or defined. (warning treated as error, aborting now) ```
> I'm not a big fan of the fact that we need the using statements for the substrait namespace but if we really want that package name then it seems...
> How to deal with the following [CI job's](https://github.com/apache/arrow/actions/runs/3557712768/jobs/5975904381) error? > > ``` > /arrow/cpp/src/arrow/engine/substrait/options.h:37: error: documented symbol 'enum ARROW_ENGINE_EXPORT arrow::engine::arrow::engine::ConversionStrictness' was not declared or defined. (warning treated as error,...
> @rtpsw Looks like the merge didn't go through cleanly. Let me know if you want me to clean this up. Note that this is a result of a GitHub...
Most CI failures seem unrelated, in particular this Substrait-test failure: ``` D:/a/arrow/arrow/cpp/src/arrow/status.cc:137: When trying to delete temporary directory: IOError: Cannot delete file 'C:/Users/RUNNER~1/AppData/Local/Temp/substrait-tempdir-q1gzn3f7/serde_test.arrow': . Detail: [Windows error 32] The process...
> @rtpsw I had to rebase this again. I've looked through it and I think this is in good shape now. If you're ok with it I will merge once...
@westonpace, I see you approved - is there anything holding up this PR?
> @rtpsw I believe it's the same failure you noticed before, which is that there is a segfault because schedule task is synchronous. In the other PR you fixed it...