rtpsw
rtpsw
@westonpace, thanks for wrapping this up.
Got it. Please bear with me as I'm learning this repo and may take a couple of iterations.
Thanks for this very detailed feedback, @jvanstraten. It adds a lot of clarity to the discussion. I generally agree with a lot of the points you made. I'll address some...
> * The protos are currently broken because enums are defined in the global namespace (like in C), so you can't duplicate JoinType like that. My local protoc (libprotoc 3.6.1)...
Sorry for my response taking some time. I'll need a couple more days before I can give this issue my full attention again.
Sorry it took a while to get back to this. Are we ready to move forward? If so, use merge or rebase to update the branch?
The branch requires updating.; in this repo, do you prefer merge or rebase?
@jvanstraten, it looks like you need to reapprove and then rebase can take place automatically.
What is expected for this repo? a merge commit or a rebase?