rtpsw

Results 104 comments of rtpsw

> It sounds like it would be better to document the existing predicates, rather than add new ones with different names. The existing set of predicates is both confusing and...

I added docs that clarify the meaning of and correspondence between `*Types()` and `Is*Type()` functions.

> Hmm... can you point out the causes for confusion? Perhaps there's a way to improve that. > > Same for incompleteness: is the set of `Type::type` predicates incomplete? if...

OK, so I'll avoid changes around the "primitive" functions and fix this PR to only: - add the missing `is_numeric`, `is_binary`, `is_string`, `is_temporal` and `is_interval` predicates - add overloads (same...

Anyone knows what the errors in the Dev jobs mean?

cc @icexelloss, @rok, @cpcloud, @westonpace

For the UDT design, please see the following: - `TabularUserDefinedFunction` in [ibis/expr/operations/tabular.py](https://github.com/ibis-project/ibis/pull/4393/files#diff-b76ba5021d3b4ff2037da7b35f01850a17de49ddf901533967e915e80ac4ca95) - [ibis/udf/table.py](https://github.com/ibis-project/ibis/pull/4393/files#diff-2eb11788febb740047c234b4c461763501697c0fe3ef887a067fe2b5c33ed26e) - [ibis/expr/operations/udf.py](https://github.com/ibis-project/ibis/pull/4393/files#diff-246b9fe50fc80d395f987589bcb81cb5e20cf0781d1de2251a8b0690b78c5aa5) - `VectorizedUDF` in [ibis/expr/operations/vectorized.py](https://github.com/ibis-project/ibis/pull/4393/files#diff-5392264b1de368f248ba38203e523e0092dc869a66dd3e348923f7658793e209)

> Please show an example of usage, in a test preferably. There is a [simple UDT tester](https://github.com/ibis-project/ibis-substrait/pull/331/files#diff-2355b8c1cbf6ba49af6b84a469f7ba99a2aa74f020c96dac6b01a36003922536R625) available in the [Ibis-Substrait draft](https://github.com/ibis-project/ibis-substrait/pull/331#issuecomment-1229187523).