rtpsw
rtpsw
> Okay, so here is the problem: users shouldn't pass invalid data to Arrow APIs (except to `Validate` and `ValidateFull`, which are explicitly designed to handle such data). So it...
> But again, during development you can call `Validate[Full]` in your own code. It doesn't really make sense to randomly add checks in Arrow functions, IMHO. Well, not really randomly,...
cc @westonpace, @pitrou
@westonpace, any idea how to fix the [Windows linker error here](https://github.com/apache/arrow/actions/runs/3122413945/jobs/5064339466)? In the past I was able to fix this by adding `inline` but this time it didn't work.
> @westonpace, any idea how to fix the [Windows linker error here](https://github.com/apache/arrow/actions/runs/3122413945/jobs/5064339466)? In the past I was able to fix this by adding `inline` but this time it didn't work....
It turns out template instantiations and attributes (in this case, visibility) do not work together nicely. When I try adding code like `template class ARROW_EXPORT ArrayVectorSourceNodeOptions`, I get compiler errors...
The CI failures look unrelated to the PR.
@westonpace, to make sure we're on the same page, what remains for this PR to go through?
@westonpace, is it a good time to get back to this PR?
> I'm a little torn on this PR. It seems that it includes #14415 which hasn't merged yet, although that is primarily because it blocked waiting for [substrait-io/substrait#342](https://github.com/substrait-io/substrait/pull/342) . At...