rtpsw

Results 104 comments of rtpsw

Thanks for all the comments. I'll try to post some quick responses, but I'll need to get back to this later, due to other priorities.

One [CI job failure](https://github.com/apache/arrow/actions/runs/3463543556/jobs/5783929365) is worth a look, but may be unrelated to the PR's changes.

@westonpace, @lidavidm - is this good to go?

> I'm still pretty reluctant to add code to handle chunked arrays. I feel it adds complexity that we will end up maintaining when chunked arrays don't really have a...

[This CI job failure](https://github.com/apache/arrow/actions/runs/3508636996/jobs/5877179392) may be related to the recent commit, though I can't think of which change could have caused it. How to set up an environment to try...

> > I'm still pretty reluctant to add code to handle chunked arrays. I feel it adds complexity that we will end up maintaining when chunked arrays don't really have...

> Does the non ordered / hash aggregation handles chunk array? AFAICS, yes, There are plenty of pre-PR `GroupBy` tests in `hash_aggregate_test.cc`, such as `CountOnly` and `SumOnly`, that create a...

> [This CI job failure](https://github.com/apache/arrow/actions/runs/3508636996/jobs/5877179392) may be related to the recent commit, though I can't think of which change could have caused it. How to set up an environment to...

> > [This CI job failure](https://github.com/apache/arrow/actions/runs/3508636996/jobs/5877179392) may be related to the recent commit, though I can't think of which change could have caused it. How to set up an environment...

> > AFAIU, aggregating tables is a valid use case that should be supported. @westonpace, let me know your thoughts. > > Aggregation of tables should be done by using...