Nick McKinney

Results 47 comments of Nick McKinney

Sure, I can prepare an implementation for that. IIRC, I didn't go that route originally because I was worried about the extreme case of ~doubling round-trips per download -- then...

@traceyyoshima - do you recall if there were any technical blockers with this item? Or has there just not been sufficient reason/demand to implement it? Looks like the NPE on...

On a related note, would be interested to get opinions on supporting Merge Key syntax: https://yaml.org/type/merge.html It's still a draft spec, but some yaml parsers do support it regardless, so...

Not a heavy impact at this time, no. I only recently encountered someone using these yaml features in the wild. And for the `merge` syntax, I haven't isolated/verified, but since...

Hey - so, given this: > Realized an issue with the heartbeat strategy: Liquibase currently makes just one connection but the heartbeat thread needs a separate connection for transaction reasons....

Dropping some notes since I did a little research on this recently: I crafted some test cases: ```kotlin @Test // failure -- adds the exclusion as described in this issue...

EDIT: see https://github.com/junit-team/junit5/issues/2811#issuecomment-1551824624 Adding another diagnostic set, for what I expect is the same root issue: JUnit version: 5.9.0-RC1 Java version: 11.0.15 OS version: Microsoft Windows [Version 10.0.14393] Stack Trace:...

@mduerig - that's a good point. I'd gladly accept a PR to improve that error reporting, if you have a clever fix in mind.

> @nmck257 The resource returned by `Git.open` is never closed in your test from [#2811 (comment)](https://github.com/junit-team/junit5/issues/2811#issuecomment-1185779074). The latest version on `main` does close it, though. Is the problem resolved for...

@marcphilipp I actually still get this same behavior on 5.9.3. In the debugger, I can see this line getting called, and trace it all the way down to a `native`...