Nick McKinney
Nick McKinney
That seems plausible -- I think a question then is if those changes belong in `rewrite-migrate-java`, instead, and should be applied for any project on jdk 8 and above. The...
Yeah, I think moving over to `rewrite-migrate-java` makes sense. Part of me would suggest leaving a small recipe like `PreferJavaVersionProperty` here in `rewrite-spring` which could replace `maven.compiler.release` with `java.version`. But,...
@ilozano2 - hmm - the goal of that recipe is certainly similar, but I expect the implementation details are fairly different. The code for `org.openrewrite.gradle.UpdateJavaCompatibility` might be a useful reference...
I think it might have to be a `ScanningRecipe`, such that it can make the choice to adjust a property file while visiting a java file, but still feels within...
@Shiroo77 The original issue description shows what I believe to be the most common pattern: calling the `Hooks...` method within `main` before calling `SpringApplication::run`. I'm not aware of any common...
Would it be too bold to simply remove the `classpath` option in favor of `classpathFromResources`? In recipe code, the set of dependencies which would both be on the production classpath...
> Use bcprov-jdk18on-1.78.1 the -ext- versions have been the same as the non "-ext-" versions for a while now, we're no longer releasing them. Can you easily clarify at which...
Hey @knutwannheden, Naïve question: is there a possible implementation where a `J` tree (like from a `JavaTemplate`) is converted into a `K` tree? This feels syntactically possible, would provide some...
Agreed, `KotlinTemplate` is valuable independent of any enhancements to make java recipes more effective on kotlin code. And I think that starts to answer some of the questions I raised...
Hey @traceyyoshima - this might be a separate issue, but I'm seeing missing types on a variety of annotation usages (in 1.8.1): All these fail for me: ```java @Test void...