Nick McKinney
Nick McKinney
Hey @Spikhalskiy -- have you had a chance to try this yet? > This specific issue should be solved by declaring `kotlin-reflect` dependency as optional. Deprecation of Kotlin 1.4 will...
This looks functionally correct and maintainable to me, which is good! Thanks for picking this up and the other one. That said, I didn't mention this in the issue, but...
hmm -- I think #4004 fixes an issue which I didn't realize was happening, and *brings* us to the state described in this issue. ie: - current state: scanning phases...
@knutwannheden yeah, that was quite the coincidence :) I agree, I could see having three different properties which accept lists of recipes: - `preconditions` (the existing) would apply to both...
@timtebeek - semi-related - would you have any concerns if I widened `FindSourceFiles` `filePattern` to `@Nullable`, and moved logic like this into `FindSourceFiles` directly? https://github.com/openrewrite/rewrite/blob/b19730693662b69321980e2559a7cab90ccd2512/rewrite-xml/src/main/java/org/openrewrite/xml/RemoveXmlTag.java#L51 At the same time, I'd...
I'm also noticing that the old `HasSourcePath` relied on a `PathMatcher` from the `FileSystem`, whereas `FindSourceFiles` uses a homegrown glob implementation in `PathUtils`. Do you happen to know if our...
Ah, that's good context. Okay, then adding curly-brace support to our custom `PathUtils` impl feels like the right choice.
this could also be extended to less-common maven version selection syntax, eg `[3.0.0,)`
maybe replace `onlyIfVersionsMatch` with `onlyIfManagedVersionIs`, with the value being a comparator symbol? eg `=`, `=`? and maybe `*` for "remove any relevant version regardless of value"? default would be `=`...
@shanman190 thanks for the references! So, I can adapt our repos here to do the publication modification in an `afterEvaluate` block. But, is it fair to say that the Nebula...