Jakub Sobon
Jakub Sobon
The pool termination code is [here](https://github.com/envoyproxy/nighthawk/blob/ed015dd6ceb77f998b34f124613c0fcd33d540e8/source/client/benchmark_client_impl.cc#L110-L131). While the code does register an idle callback, that callback only gets called if the pool is draining. Nighthawk doesn't seem to trigger pool...
With PR #827 out integration test coverage is at `74.2%`. We should organize a fixit effort to push it at least above `80%`, ideally to the `90%` range.
Nighthawk will sometimes terminate some of its worker threads early, before the specified --duration has elapsed. It reports the error: `[E] Exiting due to failing termination predicate` This error message...
Nighthawk's [check_format.py](https://github.com/envoyproxy/nighthawk/blob/d3d6d3a60ce02ea9cf0466f16534f89fdd6a2c58/tools/check_format.sh#L1) is reusing [the Envoy version](https://github.com/envoyproxy/envoy/blob/d3bd9bbef64abbf1c02fe91231eac8841901131d/tools/code_format/check_format.py#L1). Envoy includes a set of Envoy specific checks that cannot be applied in the Nighthawk codebase without code changes upstream. As an example,...
Clang-tidy started reporting a couple of `bugprone-narrowing-conversions`. The check was disabled to allow an Envoy update to proceed. The code issues should be fixed and the check re-enabled. Check disabled...
The current implementation of HTTP/3 Quic in Nighthawk reuses Envoy's `Http3::ConnectionPool` which has a hardcoded Quic's `EnvoyQuicProofVerifier`. This means that a Quic connection can only be established if the requested...
PR https://github.com/envoyproxy/nighthawk/pull/680 added more logging that is useful for a specific application of the adaptive load controller. The logging strips uninteresting parts of the NH output for brevity. It would...
Nighthawk's CI currently pins a specific commit in Envoy. If we add a separate CI workflow that will run against head of Envoy, we will get an early notification when...
PR #581 introduced an ignore list called `_TEST_SERVER_WARN_ERROR_IGNORE_LIST` in: https://github.com/envoyproxy/nighthawk/blob/master/test/integration/nighthawk_test_server.py We should investigate the reason for each of these warnings and see of we can address them.
Currently we only execute tests using the `v4only` mode: https://github.com/envoyproxy/nighthawk/blob/4d831ff59d7a53c7aa0839757b075070c7ee927d/ci/do_ci.sh#L182 This can cause our IPv6 based integration tests to go stale. We should investigate what is required to enable IPv6...