Jakub Sobon

Results 107 comments of Jakub Sobon

+1 on what ostromart said, I thought about this again and I think that we will need the option to specify what to ignore. Maybe the API can support both...

Looking more at Nighthawk's code, it might be better if we push this change up to Envoy, e.g. allow a configuration where certificate verification is optional. This seems to be...

Filed https://github.com/envoyproxy/envoy/issues/17700 to discuss with the Envoy owners.

Thank you @howardjohn, agreed that this seems worth doing. It would need definition of some new CI workflows and minor updates to the CI script [ci/do_ci.sh](https://github.com/envoyproxy/nighthawk/blob/main/ci/do_ci.sh). Please let us know...

Thank you for starting this conversation @howardjohn, for completeness, could you provide a reference to what is meant by `standard Envoy access logs`, i.e. a link t the relevant portion...

Thank you @howardjohn, adding the ability to enable the logging shouldn't be too hard and would be useful when analyzing performance patterns. There might be an impact on Nighthawk's ability...

Thank you for starting this discussion @oschaaf. To help me understand, can you clarify what do you think could be the cause of the skew, i.e. why wouldn't the assignment...

Thank you @oschaaf, I agree with your conclusions, it will be good to add the flag. If for nothing else - it will clearly document the behavior that could also...

Thank you for adding the details @oschaaf. This gives us reassurance that adding it back it should do no harm and should be an easy fix.

Thank you for your help @colimitt!