Mohamed Alkobrosli
Mohamed Alkobrosli
I can review and contribute as I have made the same upgrade to version 17, but people in OCA sent me this PR so it is better to cooperate to...
Migrating product_pricelist_fixed_currency_rate #1706
> Hi @kobros-tech > > Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown? @LoisRForgeFlow when I run precommit command it...
@kobros-tech @LoisRForgeFlow @mymage @Ivorra78 @rvalyi
@mymage @LoisRForgeFlow @OCA-git-bot I have added some tests for the new 17.0 version that were not covered in the previous 16.0 version. There was a red flag asked me to...
@LoisRForgeFlow @mymage Can we merge the pull request? /ocabot merge patch
> @kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport. Thanks for notification, I promise I...
@dnplkndll because this module has dependency we see error in dependency, and I am migrating the dependency module. I guess if there are tests, they should be applied in the...
@lmignon @sbidoul LGTM!
> Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are. @sbidoul Hi auth_jwt_demo is open now for review, https://github.com/OCA/server-auth/pull/780