OCA
[18.0][MIG] auth_jwt: Migration to 18.0
Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.
Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.
@sbidoul rebased and squashed the bot commits.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
I think there is a problem with the _authenticate override in ir_http.py. The upstream method has changed and the arguments don't match anymore.
I'm surprised this would work correctly.
I'd say we should rather override _authenticate_explicit but I'm not sure.
Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.
Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.
@sbidoul Hi auth_jwt_demo is open now for review, https://github.com/OCA/server-auth/pull/780
I commented on the auth_jwt_demo migration.
Have had a chance to look at https://github.com/OCA/server-auth/pull/752#issuecomment-2740815023 ?
@sbidoul thank you, but the method you commented on "_authenticate" is fixed as I guess, or you have an improvement?
Before merging this, we need a finalized auth_jwt_demo PR https://github.com/OCA/server-auth/pull/780, to make sure all tests pass.
On my way to merge this fine PR! Prepared branch 18.0-ocabot-merge-pr-752-by-yvaucher-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 5afea9af55bf729dfcb8e47e502d82676af33846. Thanks a lot for contributing to OCA. ❤️