web icon indicating copy to clipboard operation
web copied to clipboard

[17.0] [MIG] web_notify

Open Nikul-OSI opened this issue 1 year ago • 9 comments

Nikul-OSI avatar Feb 14 '24 06:02 Nikul-OSI

Hii @lmignon @pedrobaeza Can you please review this PR?

Nikul-OSI avatar Feb 14 '24 09:02 Nikul-OSI

/ocabot migration web_notify

I don't know enough about the module itself.

pedrobaeza avatar Feb 14 '24 09:02 pedrobaeza

@shepilov-vladislav @kevinkhao @chienandalu Can you please take a look?

Nikul-OSI avatar Feb 14 '24 09:02 Nikul-OSI

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

lmignon avatar Feb 14 '24 13:02 lmignon

commit prefixed with [PATCH X/Y]

@lmignon I captured only preserve history, I don't why it happens.

Using git format-patch --stdout origin/17_mig_nc_web_notify..ups/16.0 -- web_notify | git am -3 --keep

same commend I used others repo. too, but not add prefixed.

Nikul-OSI avatar Feb 15 '24 05:02 Nikul-OSI

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

Fixed Prefix, Ready to review.

Nikul-OSI avatar Feb 16 '24 11:02 Nikul-OSI

I can review and contribute as I have made the same upgrade to version 17, but people in OCA sent me this PR so it is better to cooperate to publish it.

I checked all parts that need to be modified in order to make the upgrade successful, and I see they are met.

if the author @Nikul-OSI needs to recheck or inspect my upgrade, here is my module:

https://github.com/kobros-tech/web_notify/tree/main

kobros-tech avatar Jun 11 '24 18:06 kobros-tech

@Nikul-OSI Do you estimate when you are going to close this PR ?

lbisiach avatar Jul 02 '24 13:07 lbisiach

@Nikul-OSI Do you estimate when you are going to close this PR ?

Yes, I reviewed, can you please create new PR. Thank you

Nikul-OSI avatar Jul 03 '24 05:07 Nikul-OSI

Superseded by #2948

pedrobaeza avatar Oct 09 '24 07:10 pedrobaeza