OCA
[17.0][MIG] product_pricelist_fixed_currency_rate: Migration to 17.0
I had to troubleshoot many bugs and they are not from my side.
I installed pandoc manually. I modified a wrong code which is written in the documentation that describes how to use hooks.
Hi @kobros-tech
Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?
@LoisRForgeFlow when I run precommit command it converts marked down file like contributers file to be marked down then it gets deleted when I commit.
I don't know why but this is what happens.
Hi @kobros-tech Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?
@LoisRForgeFlow when I run precommit command it converts marked down file like contributers file to be marked down then it gets deleted when I commit.
I don't know why but this is what happens.
I didn't realize that this was automated until now... thanks!
@mymage @LoisRForgeFlow @OCA-git-bot
I have added some tests for the new 17.0 version that were not covered in the previous 16.0 version. There was a red flag asked me to test some values and I made the update on the commit for this reason.
@LoisRForgeFlow @mymage Can we merge the pull request?
/ocabot merge patch
Sorry @kobros-tech you are not allowed to merge.
To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.
If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.
@kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport.
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1706-by-rousseldenis-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 0b97b844acc18697c87a984f401caa8d39fcdc0a. Thanks a lot for contributing to OCA. ❤️
@kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport.
Thanks for notification, I promise I will put this into my account.