Daniel Cohen

Results 23 issues of Daniel Cohen

Summary: I believe this will work better than D37865277 because it will tell us specifically which test failed. D37865277 will tell us all tests that ran after the file was...

CLA Signed
fb-exported

Differential Revision: D37898593

CLA Signed
fb-exported

Summary: This is to prevent CI failures Differential Revision: D37865277

CLA Signed
fb-exported

Summary: We don't need __init__.py's for buck, but OSS doesn't use buck targets, so we need it there. I think that's what this test is getting at. Differential Revision: D35078275

CLA Signed
fb-exported

See the stacktrace below ``` 11:40:18 celery_general.1 | [2018-10-18 15:40:18,210: ERROR/ForkPoolWorker-2] Task xxx.apps.marketo.tasks.update_marketingdata_lead.update_marketingdata_lead[9f1605d0-bfe2-4549-8cf2-91abcdc8fd7b] raised unexpected: AssertionError('daemonic processes are not allowed to have children',) 11:40:18 celery_general.1 | Traceback (most recent call...

Summary: The aim was to do this as low level as applicable. Reviewed By: bletham Differential Revision: D52735217

CLA Signed
fb-exported

Summary: Scheduler now needs to be able to: - save trials with new data even if their status didn't update - catch extra fetching errors. it already handled most of...

CLA Signed
fb-exported

Reviewed By: lena-kashtelyan Differential Revision: D51587979

CLA Signed
fb-exported

Differential Revision: D51135077

CLA Signed
fb-exported

Summary: This is a noop. These methods will be used in the follow up. Differential Revision: D51045172

CLA Signed
fb-exported