Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Use scheduler and early stopping strategy

Open danielcohenlive opened this issue 2 years ago • 2 comments

Summary: Scheduler now needs to be able to:

  • save trials with new data even if their status didn't update
  • catch extra fetching errors. it already handled most of them
  • take fetch kwargs

We have a new method to update trial properties similar to experiment.

Differential Revision: D52349938

danielcohenlive avatar Jan 17 '24 20:01 danielcohenlive

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 17 '24 20:01 facebook-github-bot

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9bc5329) 94.79% compared to head (d47adba) 94.80%.

:exclamation: Current head d47adba differs from pull request most recent head 64d7881. Consider uploading reports for the commit 64d7881 to get more accurate results

Files Patch % Lines
ax/service/tests/scheduler_test_utils.py 96.55% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2131      +/-   ##
==========================================
+ Coverage   94.79%   94.80%   +0.01%     
==========================================
  Files         462      462              
  Lines       45670    45736      +66     
==========================================
+ Hits        43294    43362      +68     
+ Misses       2376     2374       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 17 '24 20:01 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 22 '24 18:01 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 22 '24 19:01 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 25 '24 20:01 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 26 '24 14:01 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D52349938

facebook-github-bot avatar Jan 26 '24 15:01 facebook-github-bot

This pull request has been merged in facebook/Ax@7c46efb447695ee968c5ab5679bdb616678017d4.

facebook-github-bot avatar Jan 26 '24 21:01 facebook-github-bot