Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Make GenerationStrategy a GenerationStrategyInterface

Open danielcohenlive opened this issue 2 years ago • 7 comments

Summary: This is a noop. These methods will be used in the follow up.

Differential Revision: D51045172

danielcohenlive avatar Nov 10 '23 16:11 danielcohenlive

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 10 '23 16:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 10 '23 17:11 facebook-github-bot

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0d0ea07) 94.46% compared to head (75eaa7a) 94.54%.

:exclamation: Current head 75eaa7a differs from pull request most recent head b70b2ce. Consider uploading reports for the commit b70b2ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
+ Coverage   94.46%   94.54%   +0.07%     
==========================================
  Files         460      460              
  Lines       44033    44198     +165     
==========================================
+ Hits        41596    41787     +191     
+ Misses       2437     2411      -26     
Files Coverage Δ
ax/global_stopping/strategies/improvement.py 40.00% <100.00%> (ø)
ax/service/managed_loop.py 97.14% <100.00%> (ø)
ax/service/tests/test_ax_client.py 98.97% <100.00%> (ø)
ax/service/tests/test_best_point_utils.py 100.00% <100.00%> (ø)
ax/service/utils/best_point_mixin.py 79.31% <100.00%> (+0.11%) :arrow_up:
ax/service/utils/report_utils.py 83.59% <100.00%> (ø)
ax/modelbridge/best_point.py 90.62% <80.00%> (ø)
ax/modelbridge/generation_strategy.py 94.80% <93.65%> (-0.39%) :arrow_down:
ax/modelbridge/tests/test_generation_strategy.py 98.19% <93.44%> (-1.81%) :arrow_down:

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 10 '23 18:11 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 13 '23 18:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 13 '23 18:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 13 '23 19:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D51045172

facebook-github-bot avatar Nov 13 '23 19:11 facebook-github-bot