Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Assert repository (hg) status doesn't change during test runs

Open danielcohenlive opened this issue 3 years ago • 6 comments

Summary: I believe this will work better than D37865277 because it will tell us specifically which test failed. D37865277 will tell us all tests that ran after the file was created. The offending test might also be left out if it overrode tearDown(), which makes it very tough to debug!

This compares hg status on setUp() to hg status on tearDown(), asserting that setUp() was called, and that they are the same.

Differential Revision: D37901914

danielcohenlive avatar Jul 15 '22 23:07 danielcohenlive

This pull request was exported from Phabricator. Differential Revision: D37901914

facebook-github-bot avatar Jul 15 '22 23:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37901914

facebook-github-bot avatar Jul 16 '22 00:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37901914

facebook-github-bot avatar Jul 16 '22 00:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37901914

facebook-github-bot avatar Jul 16 '22 01:07 facebook-github-bot

Codecov Report

Merging #1024 (f130e8e) into main (668cade) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   94.04%   94.05%   +0.01%     
==========================================
  Files         406      406              
  Lines       35212    35305      +93     
==========================================
+ Hits        33114    33207      +93     
  Misses       2098     2098              
Impacted Files Coverage Δ
ax/core/tests/test_arm.py 100.00% <ø> (ø)
ax/core/tests/test_map_metric.py 100.00% <ø> (ø)
ax/core/tests/test_metric.py 100.00% <ø> (ø)
ax/modelbridge/tests/test_rounding.py 100.00% <ø> (ø)
ax/models/tests/test_discrete.py 100.00% <ø> (ø)
ax/models/tests/test_model_utils.py 100.00% <ø> (ø)
ax/benchmark/tests/test_problem_storage.py 100.00% <100.00%> (ø)
ax/core/tests/test_batch_trial.py 100.00% <100.00%> (ø)
ax/core/tests/test_data.py 100.00% <100.00%> (ø)
ax/core/tests/test_experiment.py 100.00% <100.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 668cade...f130e8e. Read the comment docs.

codecov-commenter avatar Jul 16 '22 01:07 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D37901914

facebook-github-bot avatar Jul 25 '22 14:07 facebook-github-bot

diff abandoned

saitcakmak avatar Aug 25 '22 21:08 saitcakmak