commenthol

Results 83 comments of commenthol

Hi @xuantuyen-nguyen-setel, Can you please confirm with a source that the "Hari Wilayah Persekutuan" or "Federal Territory Day" is observed in all Malaysia states or regions. The file already states...

Hi @lucasra1 , There is a rule [Holiday based on other holidays (bridge days)](https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#holiday-based-on-other-holidays-bridge-days) which requires gregorian dates. But I don't think this will fit your usecase, which means we...

Hi @dmwelch, I'd recommend you to start your own calendar with date-holidays-parser. Please take a look at https://github.com/commenthol/date-holidays-parser/blob/master/test/fixtures/custom.yaml and https://github.com/commenthol/date-holidays-parser/blob/master/test/Holidays.mocha.js#L18 on putting things together. For conversion from yaml to json...

The image file can be in any folder on the users disk. Watching any files that are attributed in markdown files would need to intercept in the markdown parser. A...

~For `func Saturn()` the same applies as for `func Saturn84` in terms of considering `Math.abs(B.Sin())` and `(B.Sin())^2`.~ ---- My bad. Forget this comment... `(B.Sin())^2 == Math.abs(B.Sin())^2`

Hi @pdeschen, Would you please consider publishing the update? Thanks.

In reality this project relies heavily on moment-timezone. The important data here is the reliability on the timezone which uses data from [IANA time zone database](https://www.iana.org/time-zones) that is maintained and...

Hi, I think the expected result depends on how public holidays are perceived. For your example I strongly believe that the public will celebrate New Year on January 1st. As...

Hi @flowt-au, Now I got your point. Yes for substitute days there should be a substitute flag being set. This is missing for this particular case. Will reopen as a...

Hi @pzien, Can you please run your parser changes with the data set from date-holidays? I do get some errors there related to solstice and equinox. Would be nice if...