date-holidays-parser icon indicating copy to clipboard operation
date-holidays-parser copied to clipboard
verified publisher icon commenthol

feat: replace moment-timezone with luxon

Open pzien opened this issue 3 years ago • 3 comments

pzien avatar May 19 '22 21:05 pzien

Hi @pzien, Can you please run your parser changes with the data set from date-holidays? I do get some errors there related to solstice and equinox. Would be nice if you could add some test cases here.

commenthol avatar May 21 '22 06:05 commenthol

I will do that! Thanks for feedback.

pzien avatar May 23 '22 06:05 pzien

Can I please bump this request (pending for 7 months at the time of writing)- moving to a modern esm library which uses/extends Intl.DateTime (as opposed to importing moment and moment-timezone) will result in smaller package sizes due to both tree shaking at the build stage and also not duplicating functionality in modern ES engines.

mcshaz avatar Jan 09 '23 07:01 mcshaz