commenthol

Results 83 comments of commenthol

Hi @douglaspalmer, could you please explain to me what steps would be required to update a version in the maven repository? You refer to "requiring a change in our build...

Hi @efinal, Would you please mind to add some test cases for each User-Agent? Thanks

Hi @raghunathiyer, it's not clear to me what your expectation in this case is. Please also consider adding a user-agent string.

How to deal with this notice? - a) remove HbbTV/1.x from the user_agent_parser regexes? - b) take the standard as is and the parsing as is as well?

The idea is quite old https://github.com/tobie/ua-parser/issues/55, https://github.com/tobie/ua-parser/issues/241 but never did happen due to a missing PR. @waldbaerkoch if you like feel free to add an "engine_parser" section with the regexes...

@krinkle I have no objection to add an engine parser to the reference implementation, if you would take care on the work for adding the necessary regexes for the engines....

Hello @jdibbert, I would recommend to put these UAs into the "device_parsers" section as well as both mainly refer to devices not browsers. Please check the "HbbTV" parsing.

I have strong doubts that this PR can be accepted this way, as you do not deal with real user-agent strings. I can hardly imagine that Samsung supports the oldest...

The parsing result is as follows: ``` ua: { family: 'Safari', major: '6', minor: '2', patch: '8' }, os: { family: 'Mac OS X', major: '10', minor: '8', patch: '5',...

Hi @ishwar-kumar, can you please add the user-agents affected by your change to the `tests/test_device.yaml`. Thanks.