commenthol

Results 83 comments of commenthol

@svict4, Ping. Any thoughts on my comments above?

Hi @ilyakamens, I think you are doing everything right. Problem is that moment-timezone latest.json data still has ~180kB. If you only leave the required timezones in this would reduce the...

Hi @svit4, Unfortunately there is no rule yet for "dynamic" bridge days as in your case. You describe the 2nd case to my knowledge which requires this behavior (CH-GL: Näfelser...

Hi @svict4, At https://github.com/commenthol/date-holidays-parser/pull/42 I have added a new rule which should allow you to solve the described issue with moving a holiday if there is already a holiday the...

Hi, thanks for your PR. Can you please check CONTRIBUTING.md and run ``` npx mocha test/all.mocha.js --writetests --countries PK ``` to have your changes fixed in some testcases? Thanks.

Hi @niprst, I think this should be fairly simple with adding a markdown-it plugin. Not sure yet when I'd have time to look for best supported package on npm and...

Confluence needs the images being uploaded separately. So if you switch on the confluencer option than no images can't be displayed. Instead a hidden macro is displayed which expects the...

This is a node package. Please use node instead of bun.

Hi @PanderMusubi, Your change only adds translation for the named day. It won't yet show up in any countries holiday calendar. Is this your intention?

Can you please run the (re-) generation of the test fixtures as stated in CONTRIUTING.md? Thanks. ``` npx mocha test/all.mocha.js --writetests --countries NL ```