Adrian Cole
Adrian Cole
PS sorry I didn't think about this earlier, but... let's indeed hold off on added http here. Here's why: now that the artifact ID is changed, you should be getting...
@stevesoundcloud @kristofa @dgarson @lawrencefinn @chemicL @crispywalrus @teodor-pripoae @oskarblom @LarryFinn @umichyiwan sorry for the spam, but are any of you interested in this, or helping with it? If so, Moses can...
ps this is related https://github.com/linkerd/linkerd/issues/2114
cc'ing some zipkin-finagle peeps: @mosesn @eirslett @sveinnfannar @kristofa
just had a chat with @capitanbatata about this. any thoughts about this proposal (or other ways to make intermediate spans?) it seems a nice and incremental win for those who...
> > seems like a useful feature. what happens if more than one Start nests? > would it help to take an identifier? > I suspect it would be similar...
I noticed a finagle tracer port by criteo has LocalOperationStart/Stop https://github.com/criteo/zipkin4net/tree/master/zipkin4net/Criteo.Profiling.Tracing/Annotation
whatever we do here, we should probably do consistently with other finagle tracer ports like zipkin-js and criteo's tracer cc @wirehead @eirslett @fedj
howdy we are about to merge the second identical implementation of this (after zipkin4net which is also a finagle tracer clone) https://github.com/openzipkin/zipkin-js/pull/156 ### Local tracing Sometimes you have activity that...
in brave we have a finishedspanhandler now which allows you to copy things into the span from the context. this assumes whatever you wanted isnt removed between start and finish...