Adrian Cole
Adrian Cole
I think disabled would be lying unless we wove such thing everywhere... census has disabled because they routinely use static globals to access the tracer.
how about this.. `-Dbrave.tracing.noop`? maps pretty directly to `brave.Tracing.setNoop(true)` which we won't deprecate for a long time anyway
When set at startup it is almost exactly like sample rate 0. I can look at the docs closely to tell the difference. In case a question is coming, I...
@Logic-32 thx for the feedback. One thing about noop is it doesn't disable ID provisioning, so executor wrappers are still valid (log correlation etc isn't disabled, it is data collection...
I tried integrating this with spring boot and found I had to manually call the tracing filter setter: ```java // TODO: Why isn't TracingFilter.setTracing called automatically by Dubbo's spring stuff...
sent email to [email protected]
progress on the spring boot (via spring-cloud-sleuth) side https://github.com/spring-cloud/spring-cloud-sleuth/pull/885
@chickenlj @mercyblitz so I still have one question, which is how to externally register a filter so that all providers and consumers use it (as opposed to setting it on...
spring boot (via sleuth) side of things is near perfect I added some notes https://github.com/openzipkin/sleuth-webmvc-example/compare/add-dubbo-tracing I will update the readme shortly about manual config
I think I remember people asking about this. I think some cases we can get the request/response size portably even if not all