Adrian Cole

Results 2050 comments of Adrian Cole

what we do in brave is read b3 single, but only write when people explicitly choose it. https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3Propagation.java#L131 https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SinglePropagation.java

fyi I think a lot of things like this were also discussed in census repo and some before that in the telemetry-java repo. might be worthwhile linking when that's the...

To contribute a concrete use case of this, armeria server has the ability to stash a precise "real" timestamp which is before instrumentation is invoked. While most instrumentation record duration...

Eventhough this is possible in Brave, it is still errorprone and it normally makes me cringe to see manual control of timestamps as usually this creates problems. For this reason...

Thanks for raising this. You captured my concern succinctly!

retrolambda the test source tree is an option if building with JDK 1.7 is required.

sleuth is in the middle of a big release around spring boot 2 (finchley) https://github.com/spring-cloud/spring-cloud-release/milestones We can't distract from that right now, but we do plan to look more into...

right now, brave's instrumentation for grpc can be used in sleuth. It will only read when B3 headers are used (which is not the default for census+grpc yet) https://github.com/openzipkin/brave/tree/master/instrumentation/grpc

no I just was trying to answer your question. https://github.com/spring-cloud/spring-cloud-sleuth/issues/305 is the issue originally tracking sleuth and grpc. It was closed once brave was added; people already trace heterogeneously using...

I think this is very like "firehose mode" handler discussed last meeting as all data goes here. In brave (and py zipkin) we are thinking about literally calling this firehose...