Adrian Cole

Results 2050 comments of Adrian Cole

From a config pov it is easier to use presence of an 'all handler' to know if you should add overhead to all requests vs those just sampled for export...

Definitely would be cool. We need to watch carefully where and which parsing cost (of throwable) is added

https://github.com/openzipkin/brave-opentracing/issues/44 would require brave 4.4 which is yet to be released. OT 0.30 is also pending, but we should be able to get this sorted soon.

I *think* revlock may not be an issue now, like *now!* as jaeger and also brave are on the same version of OT 0.31.0.

cool. please ping me when readying this, so we can test that propagation is compatible with other languages.

This helps a lot if you are switching from `go run golang.org/x/tools/cmd/[email protected] ...` to `go run github.com/incu6us/goimports-reviser/[email protected]` as iteratively executing `go run` is expensive in a loop, and it is...

also not sure if this requires a separate issue, but the main concern is working with multiple files. Ex I evaluate them in make, so don't need `goimports-reviser` to recurse....

yeah I don't know a good name. Just netty calls it medium. http://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#readMedium()

I have to admit that I don't regularly encounter 24-bit numbers. Then again, I haven't written a lot of binary protocol or encoding stuff either. Quick googling suggests http/2 (frame...

@kevinoliver @mosesn while the timing of implementing this isn't critical, I'd like buy-in on the approach used for binary serialization of TraceId (when 128-bits are in use). This is so...