Adrian Cole

I'm curious what you are expecting to happen in Brave? To provide a fully configured tracing component is out of scope from consuming one, for example. None of our instrumentation...

so brave-jaxrs definitely shouldn't produce the HttpTracing component. that is out of scope. ContainerParser is reasonable, but we have to make sure it doesn't break something else, and that the...

https://github.com/openzipkin/brave-example/pull/39 shows a start of a CDI + microprofile example. I'm not in tune enough with this space to know what is actually needed nowadays as there seems to be...

here's a reference from @saturnism with a workaround for spring that deletes the hyphenated headers https://github.com/spring-cloud/spring-cloud-sleuth/issues/1643

thanks. we'd need some folks interested in order to justify the maintenance (rule of 3 meaning at least 3 not co-employed that would use this). Some questions to guide the...

gotcha.. so basically we're looking at normal http client instrumentation plus perhaps a tag/service name component depending on the service discovery feature

@gquintana any chance you can raise an issue with elastic for BYOC (bring your own client). The reason we override the builder is that there are some scoping gaps if...

ex it isn't obvious here why they cannot allow the client to be overridden as an alternative to piecemeal: https://github.com/elastic/elasticsearch/blob/master/client/rest/src/main/java/org/elasticsearch/client/RestClientBuilder.java#L199-L223

meanwhile I think that method could be overridden anyway with aspectj should you have it in the classpath (not sure limitations of overriding private methods)

> In the mean time, do you think it's possible to wrap and decorate the HttpAsyncClientBuilder with custom code? The could be problems with that as they have final methods.....